Resolve "Fix quadratic time complexity for increasing of numer of species with no reactions"
requested to merge 53-fix-quadratic-time-complexity-for-increasing-of-numer-of-species-with-no-reactions into master
What does this MR do?
This MR basically moves the read of the reactions and its jacobians within the components loop. This reduced the complexity from quadratic to linear in cases where no interactions between species are needed. The source of this performance issue was explored using the llvm-xray-tools.
Can this MR be accepted?
-
I've read contribution guide -
Implemented [ ] Added/Updated tests[ ] Added/Updated documentation-
Pipelines passing -
Delete branch option set -
Fast-forwaded git merge is possible -
Added entry to CHANGELOG.md
Related issues
Closes #53 (closed)
Edited by Santiago Ospina De Los Ríos