recent updates in solverfactory broke downstream code
!453 (merged) introduced some regressions not covered in the current dune-istl tests
Parts of the problems happend, because the solver factory didn't cover all needs of down-stream modules so they started tweaking the factory. Beyond the following list of problems we should also check which features didn't match the need of downstream modules and try to adapt so that they can then use the factory.
Symptoms:
-
instantiation of SuperLU for a MultiTypeBlockVector
is not possible, but in DuMuX it also breaks the whole factory, which was previously avoided by using two different tags,IterativeSolverTag
andDirectSolverTag
. -
DuMuX internally used wrapPreconditioner4Parallel
, which was intended as an implementation detail, but not properly guarded, so it was defacto part of the interface
TODO:
-
update tests to cover the regression of MultiTypeBlockMatrix
-
reintroduce wrapPreconditioner4Parallel
and deprecate it -
check whether it is necessary to reintroduce IterativeSolverTag
andDirectSolverTag
-
fix the version number in some deprecation warning
Edited by Christian Engwer